Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.salmon-mail: 3.1.0 -> 3.1.1 #62249

Merged
merged 1 commit into from May 31, 2019
Merged

pythonPackages.salmon-mail: 3.1.0 -> 3.1.1 #62249

merged 1 commit into from May 31, 2019

Conversation

jluttine
Copy link
Member

Motivation for this change

Upgrade salmon-mail. Use this instead of #62117.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner May 30, 2019 09:50
@jluttine jluttine mentioned this pull request May 30, 2019
Closed
10 tasks
@marsam
Copy link
Contributor

marsam commented May 31, 2019

@GrahamcOfBorg build pythonPackages.salmon-mail

@marsam marsam merged commit 25f7291 into NixOS:master May 31, 2019
@marsam
Copy link
Contributor

marsam commented May 31, 2019

Tested locally on NixOS and darwin. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @marsam