Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfsUnstable: 0.8.0-rc5 -> 0.8.0 [19.03 backport] #62222

Merged
merged 1 commit into from May 30, 2019
Merged

zfsUnstable: 0.8.0-rc5 -> 0.8.0 [19.03 backport] #62222

merged 1 commit into from May 30, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aij @Mic92
zfsUnstable: 0.8.0-rc5 -> 0.8.0
dc49c5e 
Technically, this is a stable release, but it seems
prudent to test as zfsUnstable before upgrading zfsStable.

(cherry picked from commit 0c42941)
@Mic92 Mic92 changed the title zfsUnstable: 0.8.0-rc5 -> 0.8.0 zfsUnstable: 0.8.0-rc5 -> 0.8.0 [19.03 backport] May 29, 2019
@Mic92 Mic92 mentioned this pull request May 29, 2019
Merged
10 tasks
@Mic92
Copy link
Member Author

Mic92 commented May 29, 2019

@GrahamcOfBorg test zfs

fpletz
fpletz approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Mic92 Mic92 merged commit 50d5d73 into NixOS:release-19.03 May 30, 2019
@Mic92 Mic92 deleted the zfs branch May 30, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @fpletz @aij