Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zbar: 0.22 -> 0.23 #62223

Merged
merged 1 commit into from Jun 2, 2019
Merged

zbar: 0.22 -> 0.23 #62223

merged 1 commit into from Jun 2, 2019

Conversation

bricewge
Copy link
Contributor

Motivation for this change

Update zbar to 0.23 and add dbus configuration org.linuxtv.Zbar.conf to the closure.
This version adds support for --nodbus to avoid errors like Name Error (Connection ":1.1753" is not allowed to own the service "org.linuxtv.Zbar" due to security policies in the configuration file) when dbus isn't in services.dbus.packages, as it's currently the case.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth @rasendubi

@ofborg ofborg bot requested a review from 7c6f434c May 29, 2019 16:17
@7c6f434c
Copy link
Member

@GrahamcOfBorg build zbar

7c6f434c
7c6f434c approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(conditional on ofBorg not complaining about the build)

@dywedir
Copy link
Member

dywedir commented Jun 2, 2019

@GrahamcOfBorg build zbar

@dywedir dywedir merged commit 1ccd410 into NixOS:master Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bricewge @7c6f434c @dywedir