igprof: init at v5.9.16 #62215
Merged
igprof: init at v5.9.16 #62215
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
Ma27
reviewed
May 29, 2019
ktf
force-pushed
the
master
branch
2 times, most recently
from
6536577 to
e22ff20
Compare
|
For the record, I think I've addressed all the reported concerns. |
Ma27
reviewed
Jun 2, 2019
| owner = pname; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| sha256 = "0glpl97d2231gp51n3y4qvf3y1l8xzafi1sgpwc305vwc2h4dl2x"; |
There was a problem hiding this comment.
I'm getting a hash mismatch here:
hash mismatch in fixed-output derivation '/nix/store/db6iz0272sx2iszx3s1813m677g92y8m-source':
wanted: sha256:0glpl97d2231gp51n3y4qvf3y1l8xzafi1sgpwc305vwc2h4dl2x
got: sha256:0rx3mv8zdh9bmcpfbzkib3d52skzfr8600gh5gv21wcsh50jnifx
| ''; | ||
|
|
||
| license = stdenv.lib.licenses.gpl2; | ||
| maintainers = with maintainers; [ ktf ]; |
There was a problem hiding this comment.
This doesn't evaluate since maintainers is an attribute set in stdenv.lib. A typical pattern to use with maintainers is to use meta = with stdenv.lib which makes all attributes from stdenv.lib available in the meta block.
| sha256 = "0glpl97d2231gp51n3y4qvf3y1l8xzafi1sgpwc305vwc2h4dl2x"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake ]; |
There was a problem hiding this comment.
When trying to build this (with the changed hash) I get the following error:
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
UNWIND_INCLUDE_DIR
used as include directory in directory /build/source
used as include directory in directory /build/source
used as include directory in directory /build/source
used as include directory in directory /build/source
used as include directory in directory /build/source
used as include directory in directory /build/source
used as include directory in directory /build/source
used as include directory in directory /build/source
UNWIND_LIBRARY
linked by target "igprof" in directory /build/source
-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
See also "/build/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/5w2c4d5kn4c7camm5nbc43h23y9i5nlw-igprof-5.9.16.drv' failed with exit code 1
|
Apologies, I pushed from the wrong directory... :-/ |
|
New version should be fine. |
|
Build and tested locally. Let's wait for ofborg to finish and merge then. |
ofborg
bot
added
the
11.by: package-maintainer
|
@ktf thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add IgProf profiler.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)