Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mill: 0.3.6 -> 0.4.0 #62214

Merged
merged 1 commit into from May 31, 2019
Merged

mill: 0.3.6 -> 0.4.0 #62214

merged 1 commit into from May 31, 2019

Conversation

karolchmist
Copy link
Member

Motivation for this change

Update to the latest version of mill : https://github.com/lihaoyi/mill/releases

The mill binary changed and the result built file was no longer working, so I've adapted the makeWrapper command as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented May 29, 2019

cc @scalavision

@veprbl
Copy link
Member

veprbl commented May 31, 2019

@GrahamcOfBorg build mill

@veprbl veprbl merged commit 285dddb into NixOS:master May 31, 2019
@karolchmist karolchmist deleted the update-mill-0.4.0 branch June 1, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karolchmist @veprbl