Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packet python #62265

Merged
merged 2 commits into from Jun 4, 2019
Merged

Update packet python #62265

merged 2 commits into from Jun 4, 2019

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented May 30, 2019

Motivation for this change

New release of packet-python that brings in a few small features and also allows for testing from the sdist.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented May 31, 2019

could you rename the commit to python3Packages.packet-python: 1.37.1 -> 1.38.2.
This should trigger the build.

@mmlb
Copy link
Contributor Author

mmlb commented May 31, 2019

python3Packages or pythonPackages?

@mmlb
Copy link
Contributor Author

mmlb commented Jun 3, 2019

@teto ping on the name clarification please. Is there a place where python (and other) modules commit messages format is described? The manual's direction looks like a subset.

So why python3Packages vs just pythonPackages or what I think makes the most sense actually: python.pkgs.packet-python:...

@teto
Copy link
Member

teto commented Jun 4, 2019

It should have been in the https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md but the explanation is not good, I will try to update it. Meanwhile you can grep the repostiory log and you will see pythonPackages.XXX at the start.
If it works with both python 2 and 3, use pythonPackages else python3Packages. Both are an alias to python.pkgs so I suppose they are here to provide some abstraction over the underlying implementation.

@mmlb
Copy link
Contributor Author

mmlb commented Jun 4, 2019

yep I've seen all three flavors. IMO python.pkgs would make more sense for 2&3 compatible packages since pythonPackages.$foo refers to the python2 version atm and python3Packages is python3, so there doesn't seem to be one prefix to indicate both versions well. But, this is probably not the place to change convention :D.

@teto teto merged commit 77057b1 into NixOS:master Jun 4, 2019
@mmlb mmlb deleted the update-packet-python branch June 4, 2019 21:10
@mmlb
Copy link
Contributor Author

mmlb commented Jun 4, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants