Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urweb: 20180616 -> 20190217 #62266

Merged
merged 1 commit into from May 31, 2019
Merged

urweb: 20180616 -> 20190217 #62266

merged 1 commit into from May 31, 2019

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented May 30, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice May 30, 2019 21:52
@thoughtpolice
Copy link
Member

@GrahamcOfBorg build urweb

@thoughtpolice thoughtpolice merged commit a41b38e into NixOS:master May 31, 2019
@turboMaCk turboMaCk mentioned this pull request Feb 4, 2020
Closed
@turboMaCk turboMaCk mentioned this pull request Feb 4, 2020
Merged
10 tasks
turboMaCk added a commit to turboMaCk/nixpkgs that referenced this pull request Feb 4, 2020
@turboMaCk
urweb: Fix icu headers include path
4e69593 
Since NixOS#62266
urweb fails to resolve <unicode/utypepes.h> in runtime (during
compilation of project).
upstream commit: urweb/urweb@c2a217f

resolves NixOS#79218
thoughtpolice pushed a commit that referenced this pull request Feb 5, 2020
@turboMaCk @thoughtpolice
urweb: Fix icu headers include path
6d1e9c0 
Since #62266
urweb fails to resolve <unicode/utypepes.h> in runtime (during
compilation of project).
upstream commit: urweb/urweb@c2a217f

resolves #79218
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 5, 2020
@turboMaCk @dtzWill
urweb: Fix icu headers include path
e434af0 
Since NixOS#62266
urweb fails to resolve <unicode/utypepes.h> in runtime (during
compilation of project).
upstream commit: urweb/urweb@c2a217f

resolves NixOS#79218

(cherry picked from commit 6d1e9c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yrashk @thoughtpolice