Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #61657

Merged
merged 96 commits into from May 29, 2019
Merged

Staging next #61657

merged 96 commits into from May 29, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented May 18, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Jona Stubbe and others added 30 commits August 22, 2018 19:27
This allows Mesa to also build on ppc64le.
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/libgdiplus/versions
https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.0.2

* patches included, drop
* use installCheck to avoid needing to set LD_LIBRARY_PATH
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/vim/versions
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/gssdp/versions
Even if building a Ruby with documentation, there's no reason for its
baseruby to waste time building its own documentation as well.
This allows getting access to Ruby documentation through ri by doing

    nix-shell -p ruby ruby.devdoc

or by installing the ruby.devdoc package.

A setup hook will add a shim to LOAD_PATH to point ri to the devdoc
output instead of out.
Now that RI docs are installed to a seperate output, we don't need to worry
about bloating the main output, so it's reasonable for this to be enabled by
default.
@FRidh
Copy link
Member Author

FRidh commented May 18, 2019

@worldofpeace glib seems to fail https://hydra.nixos.org/build/93629754

@worldofpeace
Copy link
Contributor

@worldofpeace glib seems to fail https://hydra.nixos.org/build/93629754

Fix for that will be moved here shortly #61598

Also drop six since it was removed in the last release[0]

[0]: https://gitlab.gnome.org/GNOME/gtk-doc/blob/GTK_DOC_1_29/NEWS#L4
Fixes https://gitlab.gnome.org/GNOME/gtk-doc/issues/84 which
was breaking the documentation build for glib.

The patch was based off an upstream pr [0] but
completed with the requested changes.

[0]: https://gitlab.gnome.org/GNOME/gtk-doc/merge_requests/27
@worldofpeace
Copy link
Contributor

@FRidh For the failing things for the docs in libpsl; it appears that they never were installed even before this so I guess nobody will miss disabling them 😄

@FRidh
Copy link
Member Author

FRidh commented May 24, 2019

@worldofpeace libicalc also fails to build now
https://hydra.nixos.org/build/93852324
We should check what is causing it because this is blocking staging-next.

@worldofpeace
Copy link
Contributor

worldofpeace commented May 24, 2019

At a glance it failed like

cd /build/source/build/doc/reference/libical-glib && /nix/store/4falj4r8a92r54im5kp6zj86lwm4qxg2-gtk-doc-1.30/bin/gtkdoc-fixxref --module=libical-glib --module-dir=. --extra-dir=.. --html-dir=share/gtk-doc/html/libical-glib
Traceback (most recent call last):
  File "/nix/store/4falj4r8a92r54im5kp6zj86lwm4qxg2-gtk-doc-1.30/bin/gtkdoc-fixxref", line 57, in <module>
    fixxref.Run(options)
  File "/nix/store/4falj4r8a92r54im5kp6zj86lwm4qxg2-gtk-doc-1.30/share/gtk-doc/python/gtkdoc/fixxref.py", line 54, in Run
    highlight.append_style_defs(os.path.join(options.module_dir, 'style.css'))
  File "/nix/store/4falj4r8a92r54im5kp6zj86lwm4qxg2-gtk-doc-1.30/share/gtk-doc/python/gtkdoc/highlight.py", line 50, in append_style_defs
    os.chmod(css_file_name, 0o664)
FileNotFoundError: [Errno 2] No such file or directory: './style.css'

Idk looks like the stuff with the css file which should have been fixed in 0e27680.
See https://gitlab.gnome.org/GNOME/gtk-doc/issues/84

Looks like they might have reverted what was breaking stuff on master https://gitlab.gnome.org/GNOME/gtk-doc/issues/84#note_516043

@vcunat
Copy link
Member

vcunat commented May 26, 2019

Anything against reverting the gtk-doc update for now? So far I can only see problems from it and no expected benefits.

@FRidh
Copy link
Member Author

FRidh commented May 26, 2019

I recall just reverting the gtk-doc related changes wasn't sufficient, otherwise, definitely.

@vcunat vcunat mentioned this pull request May 26, 2019
vcunat and others added 6 commits May 26, 2019 11:03
This reverts commit 0e27680.
Let's revert the gtk-doc update for now; it causes too many problems.
This reverts commit 064ca0a.
The previous gtk-doc version won't build with our current meson.
This reverts commit 7c62ef8.
Not needed now.
@vcunat
Copy link
Member

vcunat commented May 28, 2019

Hydra:

  • x86_64-linux seems just fine;
  • aarch64-linux would need a couple more restarts for timed out stuff, but it does seem fine now already;
  • x86_64-darwinprobably too early to tell. Periodically restarting aborted jobs is easy and cheap, but there are some bigger time outs (e.g. whole haskell), and also some other failures (e.g. p11-kit not passing some security-related checks).

@FRidh
Copy link
Member Author

FRidh commented May 28, 2019

I intend to merge this later tonight. Darwin on Hydra is quite unreliable.

@vcunat
Copy link
Member

vcunat commented May 28, 2019

@grahamc any idea why there are permanently so many aborted jobs for darwin on Hydra? (or whom to ask) Most of these print a message like:

Aborted: cannot connect to ‘root@c6279b03.packethost.net’: Warning: Permanently added the ED25519 host key for IP address '147.75.70.201' to the list of known hosts. root@c6279b03.packethost.net: Permission denied (publickey).

@FRidh FRidh merged commit 97aba37 into master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet