Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnutar: 1.31 -> 1.32 #56251

Merged
merged 1 commit into from May 31, 2019
Merged

gnutar: 1.31 -> 1.32 #56251

merged 1 commit into from May 31, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 23, 2019

Motivation for this change

https://lists.gnu.org/archive/html/info-gnu/2019-02/msg00010.html

  • Not sure if Darwin fixup is needed, likely harmless if not
    but might be good to check.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 26, 2019

Thoughts on this? Small fixes, but nothing critical if now's a bad time?

@dtzWill dtzWill mentioned this pull request Mar 4, 2019
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Mar 7, 2019

@GrahamcOfBorg build gnutar

(fetch failed previously since it wasn't on the GNU mirrors yet, I think)

@dtzWill
Copy link
Member Author

dtzWill commented Mar 7, 2019

Anyone know about the Darwin fixup?

@dtzWill dtzWill mentioned this pull request Mar 12, 2019
Closed
@dtzWill dtzWill mentioned this pull request Apr 5, 2019
Closed
@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

Unfortunately appears merging and seeing letting people report failures is the only way forward here, hehe. Hopefully doesn't come to that, gnutar is hardly the sort of package that whimsically pushes versions and then leaves things broken for months, lol. Err that is to say I think it's unlikely to be problematic (as much as such is meaningful anyway).

Apologies and of course ping me liberally on any problems or concerns.

@dtzWill dtzWill merged commit 1012c31 into NixOS:staging May 31, 2019
@dtzWill dtzWill deleted the update/tar-1.32 branch May 31, 2019 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @infinisil @GrahamcOfBorg