Skip to content

pythonPackages.accupy: init at 0.1.4 #61753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2019
Merged

pythonPackages.accupy: init at 0.1.4 #61753

merged 4 commits into from
May 31, 2019
+196 −0

Conversation

costrouc
Copy link
Member

Motivation for this change

Heard a great talk at pycon about accurate floating point math wanted to play with package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@costrouc costrouc requested a review from FRidh as a code owner May 20, 2019 14:57
@costrouc costrouc force-pushed the python-accupy-init branch from 18e4bc7 to ba96e40 Compare May 20, 2019 15:02
@costrouc
Copy link
Member Author

nix-review passes

Result of nix-review pr 61753 1

6 package were build:
  • python27Packages.pipdate
  • python27Packages.pyfma
  • python37Packages.accupy
  • python37Packages.perfplot
  • python37Packages.pipdate
  • python37Packages.pyfma

@costrouc
Copy link
Member Author

HOME is required in some of the build steps (not only in tests)

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 20, 2019
@marsam
Copy link
Contributor

marsam commented May 31, 2019

@GrahamcOfBorg build python3Packages.accupy

@marsam marsam merged commit c701c71 into NixOS:master May 31, 2019
@marsam
Copy link
Contributor

marsam commented May 31, 2019

Tested locally on NixOS and darwin
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @marsam