Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simp_le: 0.9.0 -> 0.14.0 #62283

Closed
wants to merge 2 commits into from
Closed

simp_le: 0.9.0 -> 0.14.0 #62283

wants to merge 2 commits into from
+6 −5

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 31, 2019

Motivation for this change

https://github.com/zenhack/simp_le#0140

(intermediate versions are listed below)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Rudimentary testing only so far, and FWIW using acme 0.34.2, FWIW ( #61203 )

Should confirm NixOS test (and that the test uses this :P),
may confirm on live deployment but no timetable on that.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from gebner May 31, 2019 04:54
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 31, 2019
@gebner
Copy link
Member

gebner commented May 31, 2019

This fails on ofborg. You should update acme as well.

@dtzWill
Copy link
Member Author

dtzWill commented Jun 1, 2019

I have, see the mentioned PR ( #61203 ).

I'll pull those in here as well for your testing convenience, will push it shortly after re-checking :).

@dtzWill
Copy link
Member Author

dtzWill commented Jun 1, 2019

Oh, if it's not clear "acme" is built from subdirectory of the certbot source. Which might confuse things. Anyway i'd like to see confirmation from borg the stack works as well so that plan is still on 👍.

dtzWill added 2 commits June 1, 2019 00:50
@dtzWill
certbot: 0.31.0 -> 0.34.2

Verified

This commit was signed with the committer’s verified signature.
makefu Felix Richter
GPG key ID: 36F7711F3FC0F225
Verified
Learn about vigilant mode
e582984 
(also python3Packages.acme, same source)

Notes for releases I've used along the way, FWIW:

https://github.com/certbot/certbot/blob/v0.32.0/CHANGELOG.md
https://github.com/certbot/certbot/blob/v0.33.1/CHANGELOG.md
https://github.com/certbot/certbot/blob/v0.34.0/CHANGELOG.md
https://github.com/certbot/certbot/blob/v0.34.1/CHANGELOG.md
https://github.com/certbot/certbot/blob/v0.34.2/CHANGELOG.md

* add pytest dep
* add pyyaml dep
* disable tests, failure trying to invoke 'docker'
@dtzWill
simp_le: 0.9.0 -> 0.14.0

Verified

This commit was signed with the committer’s verified signature.
makefu Felix Richter
GPG key ID: 36F7711F3FC0F225
Verified
Learn about vigilant mode
2f5b682 
https://github.com/zenhack/simp_le#0140

(intermediate versions are listed below)
@dtzWill dtzWill force-pushed the update/simp_le-0.14.0 branch from 68945b1 to 2f5b682 Compare June 1, 2019 05:55
@dtzWill
Copy link
Member Author

dtzWill commented Jun 1, 2019

Oh, if it's not clear "acme" is built from subdirectory of the certbot source. Which might confuse things. Anyway i'd like to see confirmation from borg the stack works as well so that plan is still on 👍.

@GrahamcOfBorg build simp_le
@GrahamcOfBorg test acme

@ofborg ofborg bot requested a review from domenkozar June 1, 2019 06:17
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jun 1, 2019
@Lassulus
Copy link
Member

whats the status on this one?

@dtzWill
Copy link
Member Author

dtzWill commented Sep 7, 2019

I think I was concerned about the NixOS test failure (tests.acme), but I haven't investigated at all.

@JakeStanger
Copy link
Contributor

JakeStanger commented Oct 10, 2019 •
edited
Loading

The current version of simp_le is now returning 403 errors from LetsEncrypt with security.acme.certs and enableACME (nginx), so updating this is a matter of urgency.

{
  "type": "urn:acme:error:unauthorized",
  "detail": "Account creation on ACMEv1 is disabled. Please upgrade your ACME client to a version that supports ACMEv2 / RFC 8555. See https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430 for details.",
  "status": 403
}

To add to this, the package needs to be updated to 0.15.0 for ACMEv2 support, not 0.14.0 as this PR targets.

@jahkeup
Copy link
Contributor

jahkeup commented Oct 11, 2019

To add to the sense of urgency @JakeStanger noted (for bumping to 0.15.0) the ACMEv1 API is due to be shuttered at the end of the month (October 31, 2019) per their brownout schedule: https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430/3

I bumped the dependency (both certbot/acme & simp_le-client) myself in an overlay in attempt to seamlessly support the move to the v2 API, but it seems the security.acme module implementation may need some changes to make the move possible - I think there's additional flags needed though I'm not familiar enough with the specific tool to say for certain.

@JakeStanger
Copy link
Contributor

As a quick workaround for anybody who needs SSL and stumbles on this at the moment, you can use certbot certonly to generate a certificate and then move the fullchain and privkey into the acme folder.

@picnoir picnoir mentioned this pull request Oct 17, 2019
Merged
10 tasks
@fpletz
Copy link
Member

fpletz commented Oct 18, 2019

Closing in favour of #71291.

@fpletz fpletz closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner

@domenkozar domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @gebner @Lassulus @JakeStanger @jahkeup @fpletz