Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routinator: init at 0.4.0 #62267

Merged
merged 1 commit into from Jul 11, 2019
Merged

routinator: init at 0.4.0 #62267

merged 1 commit into from Jul 11, 2019

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented May 30, 2019

Motivation for this change

Adding package for routinator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Jun 1, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few minor improvements I hope you find useful.

pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
@0x4A6F 0x4A6F force-pushed the master-routinator branch 2 times, most recently from 2aafa8e to 9cb30f3 Compare June 1, 2019 09:29
@0x4A6F 0x4A6F marked this pull request as ready for review June 2, 2019 07:40
@0x4A6F
Copy link
Member Author

0x4A6F commented Jun 7, 2019

@aanderse I've updated the pull request to include the current version.

aanderse
aanderse requested changes Jun 7, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't receive any updates until you mentioned me. I'll try this out tonight. Thanks for the ping.

pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

aanderse commented Jun 8, 2019 •
edited

@0x4A6F I tried to build but got this error:

trying https://github.com/NLnetLabs/routinator/archive/0.4.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
copying path '/nix/store/zhhnxn9np7ly8gdycldvkdkzc7sgkjrq-python3.7-setuptools-41.0.1' from 'https://cache.nixos.org'...
100   127    0   127    0     0    542      0 --:--:-- --:--:-- --:--:--   542
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download source from any mirror
builder for '/nix/store/xk45j3452jwbv32a09chc2bfzz1p4xqw-source.drv' failed with exit code 1
cannot build derivation '/nix/store/lii1pq9qgbjf7p691ijnl0prwqj09jx6-routinator-0.4.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lii1pq9qgbjf7p691ijnl0prwqj09jx6-routinator-0.4.0.drv' failed

@0x4A6F
Copy link
Member Author

0x4A6F commented Jun 8, 2019 •
edited 

trying https://github.com/NLnetLabs/routinator/archive/0.4.0.tar.gz

@aanderse Should be https://github.com/NLnetLabs/routinator/archive/v0.4.0.tar.gz

@0x4A6F 0x4A6F force-pushed the master-routinator branch 2 times, most recently from fa469ff to 8d07c44 Compare June 8, 2019 15:35
aanderse
aanderse requested changes Jun 12, 2019
View reviewed changes
pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added the 6.topic: rust label Jun 12, 2019
@0x4A6F
Copy link
Member Author

0x4A6F commented Jul 10, 2019

@aanderse Are you happy with this pull request, or should I use this carnix based approach?

@aanderse
Copy link
Member

@0x4A6F Your current approach looks fine to me. I'd only ask that you squash the 2 commits into a single "routinator: init at 0.4.0" commit though, please.

@0x4A6F
Copy link
Member Author

0x4A6F commented Jul 11, 2019

@aanderse Done.

@aanderse
Copy link
Member

@GrahamcOfBorg build routinator

aanderse
aanderse requested changes Jul 11, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x4A6F Final change and then we merge. Promise 😄

pkgs/servers/routinator/default.nix Outdated Show resolved Hide resolved
@0x4A6F 0x4A6F changed the title routinator: init at v0.3.3 routinator: init at 0.4.0 Jul 11, 2019
@aanderse
Copy link
Member

@GrahamcOfBorg eval

@aanderse
Copy link
Member

@GrahamcOfBorg build routinator

@aanderse aanderse merged commit 53cad65 into NixOS:master Jul 11, 2019
@aanderse
Copy link
Member

Thanks @0x4A6F!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x4A6F @aanderse