Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.curio: patch tests #62232

Merged
merged 1 commit into from May 30, 2019
Merged

pythonPackages.curio: patch tests #62232

merged 1 commit into from May 30, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 29, 2019 •
edited

Motivation for this change

The tests currently will fail with

$ nix-shell -p python36Packages.curio
...
running install tests
ImportError while loading conftest '/build/curio-0.9/tests/conftest.py'.
py._path.local.LocalPath.ImportMismatchError: ('conftest', '/Users/beazley/Desktop/Projects/junk/curio/tests/conftest.py', local('/build/curio-0.9/tests/conftest.py'))

The package was distributed with a tests/__pycache__/ that is causing it to read invalid information.

I opened an issue on his repo to fix the pypi distribution, this is an temporary fix

@marsam

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner May 29, 2019 21:33
@ofborg ofborg bot requested a review from marsam May 29, 2019 21:53
marsam
marsam reviewed May 29, 2019
View reviewed changes
pkgs/development/python-modules/curio/default.nix Outdated
@@ -22,6 +22,7 @@ buildPythonPackage rec {
# test_aside_basic times out,
# test_aside_cancel fails because modifies PYTHONPATH and cant find pytest
checkPhase = ''
rm -r tests/__pycache__ # was packaged with this accidentally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind adding a link to the curio issue here? besides that LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marsam take a look?

@ofborg ofborg bot requested a review from marsam May 29, 2019 23:31
@marsam
Copy link
Contributor

marsam commented May 30, 2019

@GrahamcOfBorg build python36Packages.curio

@marsam marsam merged commit de3ba6b into NixOS:master May 30, 2019
@marsam
Copy link
Contributor

marsam commented May 30, 2019

Thanks @jonringer

@jonringer jonringer deleted the fix_curio branch July 9, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam