Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.xorgserver: 1.20.4 -> 1.20.5 #62275

Merged
merged 1 commit into from Jun 5, 2019
Merged

xorg.xorgserver: 1.20.4 -> 1.20.5 #62275

merged 1 commit into from Jun 5, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 31, 2019

Motivation for this change

https://lists.x.org/archives/xorg-announce/2019-May/002993.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jun 3, 2019

This isn't a large rebuild, so it could go directly to master (but it should be tested a bit at least in any case).

@dtzWill
Copy link
Member Author

dtzWill commented Jun 4, 2019

Been using it on my laptop FWIW, all good here. Only one limited data point but at least not entirely broken :).

@dtzWill dtzWill changed the base branch from staging to master June 4, 2019 06:03
@worldofpeace
Copy link
Contributor

Going about testing this now as well.

worldofpeace
worldofpeace approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine here as well

@worldofpeace worldofpeace merged commit e283999 into NixOS:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @vcunat @worldofpeace