Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xournalpp: 1.0.8 -> 1.0.12 #62280

Merged
merged 1 commit into from Jun 23, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 31, 2019

Motivation for this change
  • revisit plugin support, drop old patch
  • use lua5_3 as it seems to expect (require)
  • disable format hardening, fix build

https://github.com/xournalpp/xournalpp/releases/tag/1.0.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Runs and minor interactions seem reasonable, tablet/pen input not
      tested since I don't have such devices O:).
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

* revisit plugin support, drop old patch
* use lua5_3 as it seems to expect (require)
* disable format hardening, fix build
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

/cc maintainer @andrew-d.

Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this builds locally, that plugins are enabled now, and that they work successfully. One minor nitpick; can you remove the comment saying that plugins don't work?

@jluttine
Copy link
Member

I'm getting errors with both the old and the new version. The app just crashes immediately:

$ xournalpp

** (xournalpp:11246): WARNING **: 11:40:43.380: Failed to load "colornames.ini" (/root/.xournalpp/colornames.ini): No such file or directory


** (xournalpp:11246): WARNING **: 11:40:43.407: configfile does not exist /root/.xournalpp/settings.xml

ALSA lib pcm_dsnoop.c:638:(snd_pcm_dsnoop_open) unable to open slave
ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
ALSA lib pulse.c:243:(pulse_connect) PulseAudio: Unable to connect: Connection refused

ALSA lib pulse.c:243:(pulse_connect) PulseAudio: Unable to connect: Connection refused

Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
**
Gtk:ERROR:gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Icon 'image-missing' not present in theme Adwaita (gtk-icon-theme-error-quark, 0)

** (xournalpp:11246): WARNING **: 11:40:43.489: [Crash Handler] Crashed with signal 6

** (xournalpp:11246): WARNING **: 11:40:43.489: [Crash Handler] Wrote crash log to: /root/.xournalpp/errorlogs/errorlog.20190618-114043.log

** (xournalpp:11246): WARNING **: 11:40:43.688: Trying to emergency save the current open document…

** (xournalpp:11246): WARNING **: 11:40:43.689: Successfully saved document to "/root/.xournalpp/emergencysave.xopp"

pull bot pushed a commit to evanjs/nixpkgs that referenced this pull request Jun 23, 2019
@vcunat vcunat merged commit 8ea66b0 into NixOS:master Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants