@GrahamcOfBorg build dapper

Oh right, @ngerstle-cognite: You need to add the package to all-packages.nix as well. This can be as part of the same commit as the package itself.

Gotcha- perhaps we should add it to CONTRIBUTING.md or is that intended to contain only style requirements?
Is there a guide to packaging for inclusion here that I've overlooked?

@ngerstle-cognite Well, the all-packages.nix is kinda required, otherwise it's not addressable as an attribute.

Also, if you look in CONTRIBUTING.md there's a link named "submit changes to nixpkgs" which goes to the manual: https://nixos.org/nixpkgs/manual/#chap-submitting-changes

The manual states (among other things): Make sure it's in pkgs/top-level/all-packages.nix

Ah- missed that link. Thanks for guiding me through- I'll update my other PR (https://github.com/NixOS/nixpkgs/pull/61190/files) and keep the steps in mind going forward.

@GrahamcOfBorg build dapper

Reviewed points

• package path fits guidelines
• package name fits guidelines
• package version fits guidelines
• package build on x86_64-linux
• executables tested on x86_64-linux
• meta.description is set and fits guidelines
• meta.license fits upstream license
• meta.platforms is set
• meta.maintainers is set
• build time only dependencies are declared in nativeBuildInputs
• source is fetched using the appropriate function
• phases are respected

Possible improvements

The URL path syntax will probably go away soon, so one improvement could be to change meta.homepage to be a string. But this is for me a minor note since on deprecation it will probably result in a big treewide switch so one more place is not that bad.

But when I run the program with the flag --version it prints that the version is 0.0.0, I'm not sure where that comes from.

I'm guessing here, but it didn't help for me to add VERSION as build-flag or envoronment variable: https://github.com/rancher/dapper/blob/cdee59b8fa29579b357fc11cef9a597a1308f3bf/scripts/build

But I have not dug in deep to see where it's set.

version equaling 0.0.0 might be from https://github.com/rancher/dapper/blob/cdee59b8fa29579b357fc11cef9a597a1308f3bf/main.go#L13 as well, but I'm not that familiar with the https://github.com/urfave/cli library to be sure.

I tried to apply this diff that I made, and with that the version appears alright. I think we should do it this way, looks better:

diff --git a/pkgs/development/tools/dapper/default.nix b/pkgs/development/tools/dapper/default.nix
index 5d702cd5d71..e4b822253f2 100644
--- a/pkgs/development/tools/dapper/default.nix
+++ b/pkgs/development/tools/dapper/default.nix
@@ -17,6 +17,10 @@ buildGoPackage rec {
     sha256 = "03rmkmlvhmfwcln5v1rqww1kirxm0d1p58h6pj8f5fnhk9spb162";
   };
 
+  patchPhase = ''
+    substituteInPlace main.go --replace 0.0.0 ${version}
+  '';
+
   meta = with lib; {
     description = "Docker Build Wrapper";
     homepage = https://github.com/rancher/dapper;
@@ -25,4 +29,3 @@ buildGoPackage rec {
     maintainers = with maintainers; [ ngerstle ];
   };
 }
-

@etu updated, thanks!

@ngerstle-cognite If you can squash it to two commits (one for creating you as mantainer in the maintainer list) and one for the package it would be great, then I'll merge this.

I can squash through the github ui, but that would squash it all to one commit which isn't best practice of what we want in this case.

@etu @kuznero has volunteered as maintainer, so I've squashed everything down to a single commit.