Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minishift: 1.33.0 -> 1.34.0 #62286

Merged
merged 1 commit into from Jun 1, 2019
Merged

minishift: 1.33.0 -> 1.34.0 #62286

merged 1 commit into from Jun 1, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented May 31, 2019 •
edited

Motivation for this change

Bump to latest release 馃懠

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
minishift: 1.33.0 -> 1.34.0
2ae5777 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@GrahamcOfBorg build minishift

@worldofpeace worldofpeace merged commit 67ed5b3 into NixOS:master Jun 1, 2019
@worldofpeace
Copy link
Contributor

Thanks @vdemeester

@vdemeester vdemeester deleted the update-minishift branch June 1, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vdemeester @worldofpeace