systemd: 239.20190219 -> 241.20190221 #56184

Mic92 · 2019-02-22T08:52:47Z

Motivation for this change

changelog: https://github.com/systemd/systemd/blob/master/NEWS
Boots on my machine. I have the feeling we should have a look at our predictable
interface tests, because they changed some stuff there
It would be cool to have support for Automatic Boot Assessment in NixOS at some point

Things done

Mic92 · 2019-02-22T08:54:41Z

pkgs/os-specific/linux/systemd/default.nix

@@ -54,6 +35,8 @@ in stdenv.mkDerivation rec {
      coreutils # meson calls date, stat etc.
      glibcLocales
      patchelf getent m4
+
+      (python3Packages.python.withPackages ( ps: with ps; [ python3Packages.lxml ]))


I should have a look if splicing works as expected in the cross-compiling case. However I think it only did not work before because the python env was stringified into preConfigure.

Ok. Splicing did not work. I explicitly changed it back to buildPackages

Mic92 · 2019-02-22T09:03:44Z

cc @lheckemann in case this is relevant for 19.03.

fpletz · 2019-02-22T09:07:10Z

I was in the process of preparing systemd 240. 😄 I'm not sure whether we can get enough testing done for a systemd bump until 19.03. I'll test later today in any case.

Mic92 · 2019-02-22T09:09:13Z

I actually used your branch as a base for my rebase.
239 might be fine as well.

vcunat · 2019-02-22T09:13:12Z

Do you know about any notable down-sides of leaving 19.03 on 239?

Mic92 · 2019-02-22T09:18:16Z

A bit more effort when backporting fixes. Systemd usually has a systemd-stable fork, that backports stuff and we also start pulling patches from debian, which are currently on systemd v240. And maybe missing out some features. Also I have not found something in the NEWS file that would be super relevant for the next release.

Mic92 · 2019-02-22T09:25:30Z

nixos/modules/misc/version.nix

@@ -95,6 +95,7 @@ in
        PRETTY_NAME="NixOS ${cfg.version} (${cfg.codeName})"
        LOGO="nix-snowflake"
        HOME_URL="https://nixos.org/"
+        DOCUMENTATION_URL="https://nixos.org/nixos/manual/index.html"


This is new in v240: https://github.com/systemd/systemd/blob/f2ccf8320ac5d121cc8f50622ae3c9af1d0bfea2/NEWS#L369

andir · 2019-02-22T10:03:31Z

A few months ago I attempted to rebase our v239 onto the stable branch. It turned out to be very intrusive. Back then I wrote two additional changes for our systemd for:

andir/systemd@300073d
andir/systemd@f0afc7c

Specifially the generator change was required to fix some of the expected behaviour on NixOS.

I have not checked if those are still required or should still be applied thought.

Mic92 · 2019-02-22T10:46:47Z

@andir I suppose I can test this by running fsck.nix?

andir · 2019-02-22T15:17:14Z

@Mic92 yes, the fsck test should show that error. Just verified that.

Mic92 · 2019-02-22T15:24:14Z

I will have a look into that.

lheckemann · 2019-02-25T15:51:17Z

While this doesn't seem to be ready per se, I think we should backport this once done since maintaining an older version for 19.03 will not be any fun.

FRidh · 2019-02-27T18:23:47Z

pkgs/os-specific/linux/systemd/default.nix

@@ -54,6 +35,8 @@ in stdenv.mkDerivation rec {
      coreutils # meson calls date, stat etc.
      glibcLocales
      patchelf getent m4
+
+      (buildPackages.python3Packages.python.withPackages ( ps: with ps; [ python3Packages.lxml ]))


Suggested change

(buildPackages.python3Packages.python.withPackages ( ps: with ps; [ python3Packages.lxml ]))

(buildPackages.python3Packages.python.withPackages ( ps: with ps; [ lxml ]))

Or just buildPackages.python3.withPackages (ps: [ps.lxml])?

lheckemann · 2019-03-07T11:33:03Z

Is there anything preventing merging this?

Mic92 · 2019-03-07T16:32:19Z

@lheckemann yes: #56184 (comment)

uvNikita · 2019-03-08T23:06:31Z

#48749 should be fixed in v240 according to @arianvp. Would be nice to get it backported to 19.03 :)

arianvp · 2019-03-10T12:51:24Z

Worst case we can backport the cgroups patch on the v239 branch if this doesn't land into 19.03

vcunat · 2019-03-10T13:46:13Z

That seems quite a likely outcome to me, given the current state – I hear of almost no NixOS system running on the new version and we only have three weeks before release.

ghost · 2019-05-07T23:54:39Z

242 is out, it would be nice if we could get it done, I was also seeing a bug that is fixed in the current version.

Mic92 · 2019-05-08T06:25:56Z

I think @andir has also made some progress on this.

andir · 2019-05-08T07:45:04Z

I did run a nixpkgs release build of v241 + the two patches that I mentioned above (a07cf20 / https://github.com/andir/nixpkgs/tree/nixos-v241).

Looking at the results of my hydra build (https://hydra.h4ck.space/jobset/nixpkgs/systemd-241-full ipv6-only, sorry) it doesn't look too bad.

The failing tests are below. I am not entirely convinced that those really fail because of systemd. That is something I want to verify in the coming days.

I did a brief rebase for v242 but so far it stops very early in some meson scripts. Probably nothing big just have to sit down and take a bit of time for that. My WIP there can be seen at https://github.com/andir/systemd/tree/nixos-v242

Failed 	157887 	tests.ceph.x86_64-linux 	17h ago 	vm-test-run-All-in-one-basic-ceph-cluster 	x86_64-linux
Failed 	157979 	tests.gdk-pixbuf.x86_64-linux 	17h ago 	vm-test-run-gdk-pixbuf 	x86_64-linux
Dependency failed 	157815 	tests.minio.x86_64-linux 	17h ago 	vm-test-run-minio 	x86_64-linux
Failed 	157875 	tests.neo4j.x86_64-linux 	17h ago 	vm-test-run-neo4j 	x86_64-linux
Failed 	157703 	tests.ostree.x86_64-linux 	17h ago 	vm-test-run-ostree 	x86_64-linux
Failed 	157956 	tests.slurm.x86_64-linux 	17h ago 	vm-test-run-slurm 	x86_64-linux
Failed 	157899 	tests.flatpak.x86_64-linux 	15h ago 	vm-test-run-flatpak 	x86_64-linux
Failed 	157754 	tests.gocd-agent.x86_64-linux 	17h ago 	vm-test-run-gocd-agent 	x86_64-linux
Failed 	157938 	tests.kubernetes.dns.multinode.x86_64-linux 	17h ago 	vm-test-run-kubernetes-dns-multinode 	x86_64-linux
Failed 	157830 	tests.kubernetes.dns.singlenode.x86_64-linux 	17h ago 	vm-test-run-kubernetes-dns-singlenode 	x86_64-linux
Failed 	157740 	tests.kubernetes.rbac.multinode.x86_64-linux 	17h ago 	vm-test-run-kubernetes-rbac-multinode 	x86_64-linux
Failed 	157838 	tests.kubernetes.rbac.singlenode.x86_64-linux 	17h ago 	vm-test-run-kubernetes-rbac-singlenode 	x86_64-linux
Dependency failed 	157701 	tests.mesos.x86_64-linux 	17h ago 	vm-test-run-mesos 	x86_64-linux
Failed 	157688 	tests.mysqlReplication.x86_64-linux 	17h ago 	vm-test-run-mysql-replication 	x86_64-linux
Dependency failed 	157755 	tests.postgis.x86_64-linux 	17h ago 	vm-test-run-postgis 	x86_64-linux
Failed 	157735 	tests.prometheus-exporters.x86_64-linux 	16h ago 	vm-test-run-prometheus-exporters 	x86_64-linux
Failed 	157686 	tests.radicale.x86_64-linux 	17h ago 	vm-test-run-radicale 	x86_64-linux
Failed 	157819 	tests.taskserver.x86_64-linux 	17h ago 	vm-test-run-taskserver 	x86_64-linux

Mic92 · 2019-05-31T08:26:01Z

superseeded by #61321

Mic92 requested a review from fpletz February 22, 2019 08:52

Mic92 commented Feb 22, 2019

View reviewed changes

systemd: 239.20190219 -> 241.20190221

3ddc61f

Mic92 force-pushed the systemd-241 branch from 47f1bc3 to 3ddc61f Compare February 22, 2019 08:58

GrahamcOfBorg requested a review from edolstra February 22, 2019 09:15

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Feb 22, 2019

nixos/os-release: add documentation url

3e61338

Mic92 requested a review from infinisil as a code owner February 22, 2019 09:24

Mic92 commented Feb 22, 2019

View reviewed changes

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) labels Feb 22, 2019

lheckemann mentioned this pull request Feb 25, 2019

Install NixOs from another OS: Failed to move "/boot/loader/loader.conf" into place: Operation not permitted #46098

Closed

FRidh reviewed Feb 27, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

andir mentioned this pull request Mar 23, 2019

systemd: update debian patches url to snapshots.debian.org #58168

Merged

10 tasks

This comment has been minimized.

Sign in to view

infinisil added the 8.has: package (update) label Mar 30, 2019

flokli mentioned this pull request May 3, 2019

systemd: system units picked up from user path and user units picked up from system path #59473

Closed

andir mentioned this pull request May 11, 2019

systemd: 239 -> 242 #61321

Merged

10 tasks

Mic92 closed this May 31, 2019

Mic92 deleted the systemd-241 branch July 23, 2021 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

systemd: 239.20190219 -> 241.20190221 #56184

systemd: 239.20190219 -> 241.20190221 #56184

Mic92 commented Feb 22, 2019 •

edited

Loading

Mic92 Feb 22, 2019

Mic92 Feb 22, 2019

Mic92 commented Feb 22, 2019

fpletz commented Feb 22, 2019

Mic92 commented Feb 22, 2019 •

edited

Loading

vcunat commented Feb 22, 2019

Mic92 commented Feb 22, 2019

Mic92 Feb 22, 2019

andir commented Feb 22, 2019

Mic92 commented Feb 22, 2019

andir commented Feb 22, 2019

Mic92 commented Feb 22, 2019

lheckemann commented Feb 25, 2019

FRidh Feb 27, 2019

lheckemann Mar 4, 2019

lheckemann commented Mar 7, 2019

Mic92 commented Mar 7, 2019

uvNikita commented Mar 8, 2019

arianvp commented Mar 10, 2019

vcunat commented Mar 10, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ghost commented May 7, 2019

Mic92 commented May 8, 2019

andir commented May 8, 2019 •

edited

Loading

Mic92 commented May 31, 2019

	(buildPackages.python3Packages.python.withPackages ( ps: with ps; [ python3Packages.lxml ]))
	(buildPackages.python3Packages.python.withPackages ( ps: with ps; [ lxml ]))

systemd: 239.20190219 -> 241.20190221 #56184

systemd: 239.20190219 -> 241.20190221 #56184

Conversation

Mic92 commented Feb 22, 2019 • edited Loading

Motivation for this change

Things done

Mic92 Feb 22, 2019

Choose a reason for hiding this comment

Mic92 Feb 22, 2019

Choose a reason for hiding this comment

Mic92 commented Feb 22, 2019

fpletz commented Feb 22, 2019

Mic92 commented Feb 22, 2019 • edited Loading

vcunat commented Feb 22, 2019

Mic92 commented Feb 22, 2019

Mic92 Feb 22, 2019

Choose a reason for hiding this comment

andir commented Feb 22, 2019

Mic92 commented Feb 22, 2019

andir commented Feb 22, 2019

Mic92 commented Feb 22, 2019

lheckemann commented Feb 25, 2019

FRidh Feb 27, 2019

Choose a reason for hiding this comment

lheckemann Mar 4, 2019

Choose a reason for hiding this comment

lheckemann commented Mar 7, 2019

Mic92 commented Mar 7, 2019

uvNikita commented Mar 8, 2019

arianvp commented Mar 10, 2019

vcunat commented Mar 10, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ghost commented May 7, 2019

Mic92 commented May 8, 2019

andir commented May 8, 2019 • edited Loading

Mic92 commented May 31, 2019

Mic92 commented Feb 22, 2019 •

edited

Loading

Mic92 commented Feb 22, 2019 •

edited

Loading

andir commented May 8, 2019 •

edited

Loading