Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recurseIntoAttrs of coqPackages #62217

Closed
wants to merge 1 commit into from
Closed

recurseIntoAttrs of coqPackages #62217

wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

The purpose of this PR is to trigger the build of coqPackages in hydra to make available directly all the binary .vo final

@vbgl was this the right thing to do?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented May 29, 2019

coqPackages already has recurseIntoAttrs. What prevents hydra from building them is the call to dontDistribute.

@CohenCyril
Copy link
Contributor Author

coqPackages already has recurseIntoAttrs. What prevents hydra from building them is the call to dontDistribute.

What if I want each coqPacakges_* for each version of Coq to be built by hydra?

@vbgl
Copy link
Contributor

vbgl commented May 29, 2019

How many users will benefit from these pre-built Coq libraries? How many resources will be dedicated to them? How many users will suffer from said resources not being allocated to something else?

@CohenCyril
Copy link
Contributor Author

How many users will benefit from these pre-built Coq libraries? How many resources will be dedicated to them? How many users will suffer from said resources not being allocated to something else?

I do not know how to evaluate that. What do you think is reasonable?

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

In case of Python we already don't build for every version of Python because of resources, and Python is used far more than Coq is. Closing.

@FRidh FRidh closed this Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CohenCyril @vbgl @FRidh