Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b0500aafd557
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 594983897526
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on May 24, 2019

  1. mautrix-telegram: patch away alembic dependency 

    `alembic`[1] is a database migration tool which is invoked from the CLI
when installing the telegram bridge, but never needed during the
runtime.

The reason why `alembic` is required here is to ensure that it
exists in the Python environment when deploying the bridge. However
`alembic` requires `mautrix-telegram` in its environment to create a
database schema from the Python models.

Such a dependency relation may be possible with tools like virtualenv,
however it'll result in an infinite recursion at evaluation time in Nix.

With this patch, `mautrix-telegram` doesn't depend on `alembic` anymore
and provides a patched alembic (`pkgs.mautrix-telegram.alembic`) which
has `mautrix-telegram` in its path.

[1] https://alembic.sqlalchemy.org/en/latest/
    @Ma27
    Ma27 committed May 24, 2019
    Copy the full SHA
    0a94f89 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Merge pull request #59519 from Ma27/improve-mautrix-telegram 

    mautrix-telegram: patch away alembic dependency
    @Ma27
    Ma27 committed May 30, 2019
    Copy the full SHA
    5949838 View commit details
    Browse the repository at this point in the history