Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

murmur service: prevent silent launch failure by waiting until network is available #42860

Merged
merged 1 commit into from Jul 3, 2018
Merged

murmur service: prevent silent launch failure by waiting until network is available #42860

merged 1 commit into from Jul 3, 2018

Conversation

ldesgoui
Copy link
Contributor

@ldesgoui ldesgoui commented Jul 2, 2018

Motivation for this change

Since we use an old version of murmur, some bugs are still present:
mumble-voip/mumble#1629

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ldesgoui ldesgoui changed the title murmur service: prevent failure launch by waiting until network is available murmur service: prevent silent launch failure by waiting until network is available Jul 2, 2018
@infinisil
Copy link
Member

While network-online.target doesn't actually guarantee that the network is up, it's better than network.target for sure.

@infinisil infinisil merged commit bdac6ac into NixOS:master Jul 3, 2018
@jian-lin jian-lin mentioned this pull request May 28, 2023
Merged
12 tasks
K900 pushed a commit that referenced this pull request Jun 2, 2023
@jian-lin
nixos/murmur: make it be after network.target again
0ae9df6 
network.target was changed to network-online.target in this PR[1] to
workaround an issue[2].

The murmur version in Nixpkgs has fixed that issue[2].

[1]: #42860
[2]: mumble-voip/mumble#1629
tanneberger pushed a commit to tanneberger/nixpkgs that referenced this pull request Jun 2, 2023
@jian-lin @tanneberger
nixos/murmur: make it be after network.target again
a92eef1 
network.target was changed to network-online.target in this PR[1] to
workaround an issue[2].

The murmur version in Nixpkgs has fixed that issue[2].

[1]: NixOS#42860
[2]: mumble-voip/mumble#1629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldesgoui @infinisil @GrahamcOfBorg