@worldofpeace There are so many python packages that just stick pytestrunner into the setup_requires without conditional requirement. Are we suggesting to patch all of them? Or should we tell the pytestrunner author to change their README to always choose conditional requirement.

@worldofpeace There are so many python packages that just stick pytestrunner into the setup_requires without conditional requirement. Are we suggesting to patch all of them?

Certain people, including me, are willing to take things to the point of impracticality 😄

Or should we tell the pytestrunner author to change their README to always choose conditional requirement.

Yes, I feel like this should be done in addition to patching this for now.
We may eventually, to push its adoption, pr the change to people who aren't already doing this.

So this is done, and the tests work. I have 2 weird things that I'm confused about here though.

1. Using fetchFromGithub doesn't appear to change anything unless I change the sha256 hash. Also the sha256 hash is ALOT shorter than the sha256 hashes required by other code. In fact it's 52 characters instead of 64 characters.
2. The tests don't run automatically and I need to use a custom checkPhase. Is this is because it wasn't configured by the setup.py? And I don't really see what is the point of the pytest-runner package, is it even being used here?

Using fetchFromGithub doesn't appear to change anything unless I change the sha256 hash. Also the sha256 hash is ALOT shorter than the sha256 hashes required by other code. In fact it's 52 characters instead of 64 characters.

That is because it is base32 encoded instead of base16.

The tests don't run automatically and I need to use a custom checkPhase. Is this is because it wasn't configured by the setup.py? And I don't really see what is the point of the pytest-runner package, is it even being used here?

I think it allows you to invoke tests like setup.py pytest and I think most people alias pytest to test which is what we do default in buildPython*. Your checkPhase is fine either way.

@GrahamcOfBorg build pythonPackages.grandalf python3Packages.grandalf

Thanks 😄
On to the next one.

Just want to point out that this package is dual licensed under GPL2 and EPL1: https://github.com/bdcht/grandalf/blob/master/LICENSE. So this package should have both licenses added to the license attribute in the meta.