Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginxModules.http_proxy_connect_module: init #54420

Merged
merged 1 commit into from Mar 30, 2019
Merged

nginxModules.http_proxy_connect_module: init #54420

merged 1 commit into from Mar 30, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 21, 2019 •
edited

Motivation for this change

This adds the nginx module ngx_http_proxy_connect_module which allows
to tunnel HTTPS through an nginx proxy[1].

As this module contained patches for several nginx version, some minor
adjustments were needed:

  • Allowed each entry in nginxModules to provide patches.

  • Added an optional supports attribute to ensure that each module can
    determine if it supports the currently built nginx version (e.g. stable
    1.14 ATM or mainline 1.15 ATM).

[1] https://github.com/chobits/ngx_http_proxy_connect_module

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Ma27 Considering this is already a bit old, do you have any updates for this PR or can I merge it like this?

@Ma27
Copy link
Member Author

Ma27 commented Mar 29, 2019

I don't think so, but I'd rebase this onto the latest master later that day and do some testing just to be sure :)

@Ma27
nginxModules.http_proxy_connect_module: init
37867db 
This adds the nginx module `ngx_http_proxy_connect_module` which allows
to tunnel HTTPS through an nginx proxy[1].

As this module contained patches for several nginx version, some minor
adjustments were needed:

* Allowed each entry in `nginxModules` to provide patches.

* Added an optional `supports` attribute to ensure that each module can
  determine if it supports the currently built nginx version (e.g. stable
  1.14 ATM or mainline 1.15 ATM).

[1] https://github.com/chobits/ngx_http_proxy_connect_module
@Ma27 Ma27 force-pushed the package-nginx-http-proxy-connect-module branch from 6f55b82 to 37867db Compare March 30, 2019 00:41
@Ma27
Copy link
Member Author

Ma27 commented Mar 30, 2019

@infinisil I rebased and rechecked. Should be fine to merge IMHO.

@infinisil infinisil merged commit b511664 into NixOS:master Mar 30, 2019
@Ma27 Ma27 deleted the package-nginx-http-proxy-connect-module branch March 30, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @infinisil @GrahamcOfBorg