Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-cli: init at 0.6.2 #54426

Merged
merged 1 commit into from Feb 7, 2019
Merged

signal-cli: init at 0.6.2 #54426

merged 1 commit into from Feb 7, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jan 21, 2019

Motivation for this change

Add signal-cli to fix #51330. This is a command-line interface for sending messages on Signal. Using it requires registering a separate phone number with signal-cli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I manually tested to confirm that echo "message" | signal-cli -u FROM-NUMBER send TO-NUMBER works on NixOS and macOS 10.13.

@ghost
Copy link

ghost commented Jan 22, 2019

LGTM. Tested it with nix-review, created an account and listed my devices. CLI seems to be working.

Because it's a very privacy focused application, I think it's good to verify the signature of the download (the creator signs his releases).

makefu
makefu approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested application with nix-review, works as expected.

@Mic92 Mic92 merged commit c871a5c into NixOS:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: signal-cli
4 participants
@ivan @makefu @Mic92 @GrahamcOfBorg