ncurses: use github mirror #54419
ncurses: use github mirror #54419
Conversation
Development releases of ncurses are uploaded but often also removed again. This is causing a lot of trouble, so let's instead use a GitHub mirror.
| # Note the version needs to be adjusted. | ||
| rev = "acb4184f8f69fddd052a3daa8c8675f4bf8ce369"; | ||
| in fetchurl { | ||
| url = "https://github.com/mirror/ncurses/archive/${rev}.tar.gz"; |
There was a problem hiding this comment.
Is there a documented case where this broke our checksum?
There was a problem hiding this comment.
As far as I know the times where the generated archives could have different hashes is already some years ago.
There was a problem hiding this comment.
If it's the case it still happens we'll just switch to fetchgit.
There was a problem hiding this comment.
Ahh but then we can't use fetchurlBoot.
| ]; | ||
| sha256 = "10s9r1lci2zym401ddw4w9cb3jmgprjnzpzr08djl3mmr0vpqnx2"; | ||
| # We cannot use fetchFromGitHub (which calls fetchzip) | ||
| # because we need to be able to use fetchurlBoot. |
There was a problem hiding this comment.
Why is fetchurlBoot needed here?
When should the rev and version be updated?
There was a problem hiding this comment.
ncurses is used when doing bootstrapping stdenv, where fetchurlBoot is only available..
There was a problem hiding this comment.
I guess rev is used in case they delete releases.
There was a problem hiding this comment.
"releases" aren't tagged, they're actually just individual commits.
There was a problem hiding this comment.
ncurses is used when doing bootstrapping stdenv, where fetchurlBoot is only available..
Maybe just expand the comment with that.
|
ping @samueldr for backport request |
|
I've cherry-picked it to |
Development releases of ncurses are uploaded but often also removed
again. This is causing a lot of trouble, so let's instead use a
GitHub mirror.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)