Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-review: 1.0.2 -> 1.0.4 #54422

Merged
merged 1 commit into from Jan 21, 2019
Merged

nix-review: 1.0.2 -> 1.0.4 #54422

merged 1 commit into from Jan 21, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
$ nix-shell -p nix-review --command "nix-review pr https://github.com/NixOS/nixpkgs/pull/54422"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title nix-review: 1.0.2 -> 1.0.3 [WIP] nix-review: 1.0.2 -> 1.0.3 Jan 21, 2019
@Mic92
Copy link
Member Author

Mic92 commented Jan 21, 2019

Do not merge yet. I just found a bug.

@ghost
Copy link

ghost commented Jan 21, 2019 •
edited by ghost

Can you give me a hint how I can test this out as well?

Nevermind, found the repository and the instructions are there.

@Mic92
Copy link
Member Author

Mic92 commented Jan 21, 2019

Still needs this fix: Mic92/nixpkgs-review#40. See the project readme for usage examples

@Mic92
nix-review: 1.0.2 -> 1.0.4
f6d6e5d 
- also accept the full url of pull request i.e.
  NixOS#54323
- stream-parse nix-env's eval output
- fix logs for failed builds issued by remote builders
- prepare code for overlays like: NixOS#53934
@Mic92 Mic92 changed the title [WIP] nix-review: 1.0.2 -> 1.0.3 [WIP] nix-review: 1.0.2 -> 1.0.4 Jan 21, 2019
@Mic92 Mic92 changed the title [WIP] nix-review: 1.0.2 -> 1.0.4 nix-review: 1.0.2 -> 1.0.4 Jan 21, 2019
@Mic92
Copy link
Member Author

Mic92 commented Jan 21, 2019

Bug was fixed.
@GrahamcOfBorg build nix-review

@Mic92 Mic92 merged commit 674c882 into NixOS:master Jan 21, 2019
@Mic92 Mic92 deleted the nix-review branch January 21, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg