Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: split into common, flashback and 3 #54415

Closed
wants to merge 1 commit into from
Closed

nixos/gnome3: split into common, flashback and 3 #54415

wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 21, 2019

Motivation for this change

Allow using flashback without GNOME Shell

cc @hedning @worldofpeace @chpatrick

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor Author

jtojnar commented Jan 21, 2019

For this to have any effect, we will need to extract the session files from gnome-session, similarly to how we do it for gnome-flashback package.

worldofpeace
worldofpeace reviewed Jan 21, 2019
View reviewed changes
nixos/modules/services/x11/desktop-managers/gnome-common.nix

fonts.fonts = [ pkgs.dejavu_fonts pkgs.cantarell-fonts ];

environment.extraInit = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to quote https://github.com/NixOS/nixpkgs/pull/48637/files#r249038169 now for consideration

@jtojnar
Copy link
Contributor Author

jtojnar commented Jan 21, 2019

Would it make sense to share some of this with elementary? Also I am thinking about making the sessionPath option internal.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jan 21, 2019 •
edited

Would it make sense to share some of this with elementary?

I'm sure we could work it to be this way, and in the end they have very similar configuration.
Though they don't use a lot of gnome's dbus services.

I've also noticed a usecase where people would like to use less of gnome's dbus services in general.

Also I am thinking about making the sessionPath option internal.

Don't people need that to use extra shell extensions in nixpkgs?

@jtojnar
Copy link
Contributor Author

jtojnar commented Jan 21, 2019

Don't people need that to use extra shell extensions in nixpkgs?

We have converged on hard-coding the typelib paths into the extension code.

@worldofpeace
Copy link
Contributor

Don't people need that to use extra shell extensions in nixpkgs?

We have converged on hard-coding the typelib paths into the extension code.

Right as in gpaste, for that it would be nice if we had some sort of setup hook too.

@jtojnar jtojnar added this to the 19.03 milestone Jan 23, 2019
hedning
hedning reviewed Jan 25, 2019
View reviewed changes
nixos/modules/services/x11/desktop-managers/gnome-common.nix
enable = mkOption {
default = false;
internal = true;
description = "Enable Gnome 3 desktop manager.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be something like «Enable common gnome services».

hedning
hedning reviewed Jan 25, 2019
View reviewed changes
nixos/modules/services/x11/desktop-managers/gnome-common.nix
};
};

services.xserver.desktopManager.gnome3 = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can't easily put this under services.xserver.desktopManager.gnome-common since it could break existing configs :/

@lheckemann
Copy link
Member

Taking this out of the 19.03 milestone since it's a feature and still marked as WIP.

@lheckemann lheckemann removed this from the 19.03 milestone Feb 25, 2019
This was referenced Apr 15, 2019
Closed
Closed
@aaronjanse
Copy link
Member

Apart from changing the gnome description and resolving merge conflicts, are there any major changes that need to be made to this PR?

@worldofpeace worldofpeace mentioned this pull request Aug 26, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

I believe we can close this, it should be pretty easy to split out flashback from GNOME 3 with #67466. And we have stepping stones on the tracker.

@jtojnar jtojnar deleted the nixos-gnome-split branch September 4, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jtojnar @worldofpeace @lheckemann @aaronjanse @hedning @GrahamcOfBorg