Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #6960: Remove parts of generate used only for MSVC pre-2015. #7076

Merged
merged 1 commit into from Jan 21, 2019
Merged

Cleanup #6960: Remove parts of generate used only for MSVC pre-2015. #7076

merged 1 commit into from Jan 21, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Jan 21, 2019

#6960 removed support for MSVC pre-2015, but some of the dynamic parts were still being generated (and discarded) by generate/generate.vbs

glx22
glx22 approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except expected EOL issues it works as intended

@PeterN PeterN merged commit 41d4792 into OpenTTD:master Jan 21, 2019
@PeterN PeterN deleted the remove-generate-leftovers branch January 21, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterN @glx22