Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite-agent3: 3.0.1 -> 3.8.2 #54430

Merged
merged 3 commits into from Jan 28, 2019
Merged

buildkite-agent3: 3.0.1 -> 3.8.2 #54430

merged 3 commits into from Jan 28, 2019

Conversation

yorickvP
Copy link
Contributor

@yorickvP yorickvP commented Jan 21, 2019

Motivation for this change

Updated the package. Module changes will come later.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP
Copy link
Contributor Author

(cc: @pawelpacana @zimbatm @rvl)

@rvl
Copy link
Contributor

rvl commented Jan 26, 2019

Hi @yorickvP, thanks, I built your branch and tested buildkite-agent --version and it's fine.
In the time since you submitted the PR, there have already been two more releases! The latest as of now is v3.8.4.

@yorickvP
Copy link
Contributor Author

Updated! :)

@zimbatm zimbatm merged commit 83520c3 into NixOS:master Jan 28, 2019
@yorickvP yorickvP deleted the upd-bk-agent branch January 29, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants