Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package multiple python modules #54413

Merged
merged 5 commits into from Jan 21, 2019
Merged

Package multiple python modules #54413

merged 5 commits into from Jan 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 21, 2019 •
edited by ghost

Motivation for this change

I want to package these modules so that I can use a nix-shell for development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from FRidh as a code owner January 21, 2019 11:06
@ghost
Copy link
Author

ghost commented Jan 21, 2019

@dotlambda You said I should ping you when I open the new PR with multiple packages.

@ghost
Copy link
Author

ghost commented Jan 21, 2019

I also submitted a PR to each of the projects to include the tests in their pypi tarballs. I will update the packages when / if they get merged.

@ghost
Copy link
Author

ghost commented Jan 21, 2019 •
edited by ghost

@dotlambda ping for done.

Not ready, I want to add my pgp key / sign my commits.

Ready.

@dotlambda
Copy link
Member

@GrahamcOfBorg build pythonPackages.djangorestframework-jwt python3Packages.djangorestframework-jwt pythonPackages.django-rest-auth python3Packages.django-rest-auth pythonPackages.django-cors-headers python3Packages.django-cors-headers pythonPackages.braintree python3Packages.braintree

@dotlambda dotlambda merged commit e23c5ec into NixOS:master Jan 21, 2019
@ghost
Copy link
Author

ghost commented Jan 21, 2019

@dotlambda thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @GrahamcOfBorg