Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spideroak: 7.1.0 -> 7.3.0 #55010

Closed
wants to merge 1 commit into from
Closed

spideroak: 7.1.0 -> 7.3.0 #55010

wants to merge 1 commit into from

Conversation

nathantalewis
Copy link
Contributor

Motivation for this change

A few new versions of SpiderOak have been released.

Things done

This bumps the version and removes 32 bit support, since it is no longer supported upstream for Linux.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nathantalewis
spideroak: 7.1.0 -> 7.3.0
d840109 
As of version 7.3.0, Spideroak no longer supports 32 bit on Linux.
@nathantalewis
Copy link
Contributor Author

This is my first PR for nixpkgs, so I'm not really sure how to do the things the PR template is asking (testing on a sandbox, using nixos/tests, etc...)

Since this is mostly a version bump, let me know how important those things are and if I need to do them or if the reviewer does them. If I need to do them, it could be a while before I'm able to get back to this.

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build spideroak

ryantm
ryantm requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

fixed-output derivation produced path '/nix/store/irq9g129qrc9gs560mvxsjd9hivzi7cp-SpiderOakONE-7.3.0-slack_tar_x64.tgz' with sha256 hash '1igf0pkkr4dmwnyvbx18fkdvd8k4g2vnwsbw47qimj5whfrs4v3d' instead of the expected hash '14sp1yh794169ag089sscjq18gjv2rfzdf43jlp60wx6k392ykx5'
cannot build derivation '/nix/store/5ks1bhh51saic33cqbhg2acir85lv87z-spideroak-7.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yxdpsx8pand4a2naa78qbn1plgar32kv-env.drv': 1 dependencies couldn't be built

Looks like the hash might be incorrect. It doesn't build for me at least.

I think all the architecture stuff at the top can be removed.

@nathantalewis
Copy link
Contributor Author

It looks like 7.5.0 is out now. I'll close this PR and if nobody else has by then, I'll make a new PR when I get around to updating.

@nathantalewis nathantalewis mentioned this pull request Mar 27, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nathantalewis @ryantm @GrahamcOfBorg @Janik-Haag