Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neo4j: 3.4.10 -> 3.5.2 #55047

Merged
merged 2 commits into from Feb 1, 2019
Merged

neo4j: 3.4.10 -> 3.5.2 #55047

merged 2 commits into from Feb 1, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 1, 2019 •
edited

Motivation for this change

I noticed neo4j in nixpkgs was outdated (most likely because neo4j-admin was removed and @r-ryantm couldn't autobump anymore).

Also added a test.

cc @offlinehacker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
neo4j: 3.4.10 -> 3.5.2
2436c97 
neo4j-shell is gone
alyssais
alyssais reviewed Feb 1, 2019
View reviewed changes
pkgs/servers/nosql/neo4j/default.nix Show resolved Hide resolved
nixos/tests/neo4j.nix Outdated Show resolved Hide resolved
@alyssais
Copy link
Member

alyssais commented Feb 1, 2019

@GrahamcOfBorg build neo4j

@alyssais alyssais merged commit a06952d into NixOS:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @alyssais @GrahamcOfBorg