New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm7: replace patch with official upstream commit #54998
Conversation
Hopefully this also addresses any problems enountered with the patch used previously.
@GrahamcOfBorg build llvm_7 |
Should probably go straight to staging-next? |
I'm happy to target staging-next, but I'm not sure I understand why? Shouldn't it go to staging, staging merges into staging-next? Anyway if it's useful there that works for me, and feel free to pick the commit as needed... |
Aww Darwin builder didn't get anywhere near LLVM :( haha. |
If a breakage is considered a blocker for merging staging-next to master, it's usually better to first stabilize staging-next before merging in more of other staging changes. EDIT: I don't really know how severe this particular problem is. |
Alright, I'm not sure either. I'll merge to staging and we can pick it into staging-next if there's a need. |
Rustc depends on llvm-7, so the breakage is pretty big. In particular the unstable job won't pass due to inkscape depending on rustc. |
(cherry picked from commit 442a74b)
Picked to
|
http://lists.llvm.org/pipermail/llvm-dev/2019-February/129985.html <-- 7.1.0 will include this :). |
Hopefully this also addresses any problems enountered
with the patch used previously.
Motivation for this change
cc #54370
(although this may not fix everything, should fix Optional error)
Same goal as #54122, but uses upstream commit instead of patch from
Debian (which I believe matches upstream's first attempt to fix this as
well).
Basically this was tricky to get right on all compilers,
thankfully it seems to have been sorted out.
Fingers crossed :).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)