Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/redmine: add an extraEnv option, enable automatic log rotation #55050

Merged
merged 1 commit into from Feb 4, 2019
Merged

nixos/redmine: add an extraEnv option, enable automatic log rotation #55050

merged 1 commit into from Feb 4, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 1, 2019 •
edited

Motivation for this change

Some additional configuration for Redmine needs to be written to an additional_environment.rb file for Redmine. This PR creates that file and allows the user to append whatever they need to it. As an added bonus log rotation is now configured by default so users won't have an ever expanding log file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
nixos/redmine: add an extraEnv option (which could be used to turn on…
52bd7c5 
… debug logging, etc...), enable automatic log rotation
@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2019

@GrahamcOfBorg test redmine

@aanderse
Copy link
Member Author

aanderse commented Feb 4, 2019

@7c6f434c just in case you're willing and able :)

@7c6f434c
Copy link
Member

7c6f434c commented Feb 4, 2019

(By default I ignore module changes because I don't use NixOS mainline anymore, but this does seem simple enough)

@7c6f434c 7c6f434c merged commit 7ff8a16 into NixOS:master Feb 4, 2019
@aanderse aanderse deleted the redmine-extra-env branch February 4, 2019 17:37
@aanderse
Copy link
Member Author

aanderse commented Feb 4, 2019

@7c6f434c that makes sense. I hope you don't mind me bugging you for relatively simple merges, because as mentioned previously you do have the most context on this...

Thanks for the merge!

@7c6f434c
Copy link
Member

7c6f434c commented Feb 4, 2019

Sure, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @7c6f434c @GrahamcOfBorg