Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bazel-remote as a go package and a nixos module #54996

Closed
wants to merge 1 commit into from
Closed

add bazel-remote as a go package and a nixos module #54996

wants to merge 1 commit into from

Conversation

shmish111
Copy link
Contributor

@shmish111 shmish111 commented Jan 31, 2019 •
edited

Motivation for this change

Add https://github.com/buchgr/bazel-remote as a NixOS module

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Feb 3, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my comments, you need to split this PR into three commits in this order:

  • One for adding yourself as a maintainer
  • One for adding the package
  • And one for adding the NixOS module

And format your commit message according to the Contribution Guidelines, also linked to from the PR template.

nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
pkgs/servers/bazel-remote/default.nix Show resolved Hide resolved
pkgs/servers/bazel-remote/default.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
nixos/modules/services/misc/bazel-remote.nix Show resolved Hide resolved
@shmish111
Copy link
Contributor Author

Thanks @infinisil I'll split it up but I just want to wait for your answers to my questions first.

shmish111 added a commit to shmish111/nixpkgs that referenced this pull request Feb 4, 2019
@shmish111
nixos/bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140
f70e291 
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on:
  NixOS#54996
  NixOS#55187
@shmish111
Copy link
Contributor Author

closing in favour of:
#55184
#55187
#55188

@shmish111 shmish111 closed this Feb 4, 2019
@shmish111 shmish111 mentioned this pull request Feb 4, 2019
Closed
10 tasks
@infinisil
Copy link
Member

I said to split it into three commits, not pull requests. Having PR's that depend on each other isn't very nice. But it doesn't matter now

@kalbasit kalbasit mentioned this pull request Mar 21, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shmish111 @infinisil @GrahamcOfBorg