Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk-doc: 1.28 -> 1.29 #55051

Merged
merged 1 commit into from Feb 3, 2019
Merged

gtk-doc: 1.28 -> 1.29 #55051

merged 1 commit into from Feb 3, 2019

Conversation

pSub
Copy link
Member

@pSub pSub commented Feb 1, 2019

Motivation for this change

Changes in 1.29

o 674163 : –   html-build.stamp rule broken for out-of-tree builds with absolute paths
o 795744 : Too much escaped string - " & lt;child > " in description of " GtkOverlay as GtkBuildable " section
o 796011 : Crash in ScanDirectory caused by overlooked use of renamed dir variable
o 796012 : Several places in rebase.py incorrectly use match.groups(1) instead of match.group(1), one causes a crash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub pSub merged commit 5eebe43 into master Feb 3, 2019
@pSub pSub deleted the update-gtk-doc branch February 3, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants