Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-deps: 2018-11-01 -> 2019-02-01 #55035

Merged
merged 1 commit into from
Feb 17, 2019
Merged

bazel-deps: 2018-11-01 -> 2019-02-01 #55035

merged 1 commit into from
Feb 17, 2019
+7 −8

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Feb 1, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@uri-canva
bazel-deps: 2018-11-01 -> 2019-02-01

Verified

This commit was signed with the committer’s verified signature.
MichaReiser Micha Reiser
SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode
2b2854e
@uri-canva uri-canva requested a review from Profpatsch as a code owner February 1, 2019 08:43
@uri-canva
Copy link
Contributor Author

Cannot test this on linux because it's failing on master already.

@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 1, 2019
@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel-deps

@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

Was already failing on linux, succeeds on darwin, so let's merge it.

@ryantm ryantm merged commit a954ca5 into NixOS:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uri-canva @Profpatsch @ryantm @GrahamcOfBorg