Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-deps: 2018-11-01 -> 2019-02-01 #55035

Merged
merged 1 commit into from Feb 17, 2019
Merged

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Feb 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@uri-canva
Copy link
Contributor Author

Cannot test this on linux because it's failing on master already.

@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel-deps

@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

Was already failing on linux, succeeds on darwin, so let's merge it.

@ryantm ryantm merged commit a954ca5 into NixOS:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants