Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-router: 0.2.3 -> 0.2.5 #55041

Merged
merged 1 commit into from Feb 1, 2019
Merged

kube-router: 0.2.3 -> 0.2.5 #55041

merged 1 commit into from Feb 1, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 1, 2019

Motivation for this change

Contains various bugfixes and improvements. Among them, a critical fix for an issue that causes kube-router to crash when declaring network policies without port numbers.

Manually tested with positive results on our kubernetes cluster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb self-assigned this Feb 1, 2019
@srhb srhb merged commit a111a5e into NixOS:master Feb 1, 2019
@johanot johanot deleted the kube-router-v0.2.5 branch February 1, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srhb srhb

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @srhb @GrahamcOfBorg