New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Allow AI companies to start immediately. #7151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
reviewed
Jan 31, 2019
PeterN
reviewed
Jan 31, 2019
PeterN
reviewed
Jan 31, 2019
SamuXarick
force-pushed
the
start_date-=-0
branch
from
January 31, 2019 16:09
e373e78
to
e773c3b
Compare
glx22
reviewed
Jan 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScriptConfig::AddRandomDeviation() could be simpler, just assume "start_date" exists only for AIs, and if it's 0 then don't add random to it
SamuXarick
force-pushed
the
start_date-=-0
branch
from
January 31, 2019 18:40
e773c3b
to
941f932
Compare
PeterN
reviewed
Jan 31, 2019
SamuXarick
force-pushed
the
start_date-=-0
branch
from
January 31, 2019 19:07
941f932
to
ba617cf
Compare
PeterN
reviewed
Jan 31, 2019
SamuXarick
changed the title
Codechange: Allow AI companies start_date to be 0
Change: Allow AI companies to start immediately.
Jan 31, 2019
SamuXarick
force-pushed
the
start_date-=-0
branch
2 times, most recently
from
February 1, 2019 14:39
1539a46
to
7069060
Compare
PeterN
reviewed
Feb 1, 2019
Allow multiple AIs to possibly start in the same tick. start_date = 0 becomes a special case, where random deviation does not occur. If start_date was not already 0, then a minimum value of 1 must apply.
SamuXarick
force-pushed
the
start_date-=-0
branch
from
February 1, 2019 17:04
7069060
to
e4fa330
Compare
PeterN
approved these changes
Feb 2, 2019
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
Feb 4, 2019
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
Feb 4, 2019
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
Feb 4, 2019
… or with shift pressed.
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
Feb 4, 2019
… or with shift pressed.
PeterN
added a commit
that referenced
this pull request
Feb 11, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
… or with shift pressed.
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
…set to a random AI. (OpenTTD#7223)
TrueBrain
added a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Mar 24, 2019
…tiplayer, or with shift pressed." This reverts commit b1e40b6. This is a fix for a patch that will be reverted in the next commit.
TrueBrain
added a commit
that referenced
this pull request
Mar 24, 2019
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
… or with shift pressed.
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
…set to a random AI. (OpenTTD#7223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple AIs to possibly start in the same tick.
start_date = 0 becomes a special case, where random deviation does not occur.
If start_date was not already 0, then a minimum value of 1 must apply.