Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket, racket-minimal: 7.1 -> 7.2 #54994

Merged
merged 1 commit into from Feb 4, 2019
Merged

racket, racket-minimal: 7.1 -> 7.2 #54994

merged 1 commit into from Feb 4, 2019

Conversation

clacke
Copy link
Contributor

@clacke clacke commented Jan 31, 2019

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clacke
racket, racket-minimal: 7.1 -> 7.2
085797a 
The old src/configure has been split into src/lt/configure for
classical Racket and src/cs/c/configure for Racket CS (Racket on Chez
Scheme).
marsam
marsam reviewed Feb 4, 2019
View reviewed changes
pkgs/development/interpreters/racket/default.nix
@@ -67,7 +67,7 @@ stdenv.mkDerivation rec {

preConfigure = ''
unset AR
for f in src/configure src/racket/src/string.c; do
for f in src/lt/configure src/cs/c/configure src/racket/src/string.c; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Racket was updated in #54971, but this change is valid

@7c6f434c 7c6f434c merged commit f81c0c1 into NixOS:master Feb 4, 2019
@clacke clacke deleted the racket72 branch February 4, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clacke @marsam @7c6f434c @GrahamcOfBorg