Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetBSD cross compiling #55023

Merged
merged 2 commits into from Feb 26, 2019
Merged

NetBSD cross compiling #55023

merged 2 commits into from Feb 26, 2019

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ericson2314
Ericson2314 approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@matthewbauer matthewbauer changed the title [wip] netbsd cross compiling netbsd cross compiling Feb 4, 2019
@matthewbauer matthewbauer changed the title netbsd cross compiling NetBSD cross compiling Feb 4, 2019
@matthewbauer matthewbauer changed the base branch from master to staging February 4, 2019 20:43
@matthewbauer matthewbauer changed the base branch from staging to master February 4, 2019 20:44
@Ericson2314
Copy link
Member

Ericson2314 commented Feb 5, 2019 •
edited

Wooo! Staging and then it's a-go? We should get this on some their mailing list or whatever. It should be a great way to draw in more people to Nix/Nixpkgs/NixOS.

@matthewbauer
Copy link
Member Author

To avoid breaking anything I might wait until branching off for 19.03

@matthewbauer
Copy link
Member Author

I also am trying to upstream the GCC patch here:

https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00198.html

@Ericson2314
Copy link
Member

Good luck with the upstream!

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2019

Hopefully easier then getting stuff into the LLVM.

@matthewbauer matthewbauer changed the base branch from master to staging February 26, 2019 20:55
matthewbauer and others added 2 commits February 26, 2019 15:55
@matthewbauer
netbsd: add cross target
aab8c7b
@matthewbauer
bintools-wrapper: fix unknown emulation error message
85536e8 
Using the + operator with throw doesn’t seems to work properly. You
need to use antiquotes here to get the targetPlatform config included.
@matthewbauer matthewbauer merged commit 51d6b84 into NixOS:staging Feb 26, 2019
vcunat
vcunat reviewed Apr 7, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -23258,8 +23260,10 @@ in

fts = if stdenv.hostPlatform.isMusl then netbsd.fts else null;

inherit (recurseIntoAttrs (callPackages ../os-specific/bsd { }))
netbsd;
netbsd = callPackages ../os-specific/bsd/netbsd {};
Copy link
Member

@vcunat vcunat Apr 7, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removed recurseIntoAttrs and thus the packages aren't built by Hydra anymore. Was that intentional?

@vcunat
Copy link
Member

vcunat commented Apr 7, 2019

The bigger problem is that netbsd-make won't build on Darwin anymore, breaking lots of packages, e.g. https://hydra.nixos.org/job/nixpkgs/trunk/getent.x86_64-darwin

@vcunat
Copy link
Member

vcunat commented Apr 7, 2019 •
edited

Well, netbsd.make won't build even on x86_64-linux on current nixpkgs master (though the error message seems different).

@matthewbauer
Copy link
Member Author

Very weird. I’ll look into it

@marsam marsam mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

@pSub pSub pSub approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@nbp nbp Awaiting requested review from nbp

@danbst danbst Awaiting requested review from danbst

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthewbauer @Ericson2314 @Mic92 @vcunat @pSub @GrahamcOfBorg