Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airsonic: Add virtualHost option to set up nginx virtual host #55024

Merged
merged 1 commit into from Feb 12, 2019
Merged

airsonic: Add virtualHost option to set up nginx virtual host #55024

merged 1 commit into from Feb 12, 2019

Conversation

telotortium
Copy link
Contributor

Modeled after nixos/modules/services/web-apps/tt-rss.nix. The setup is
slightly non-intuitive, so I think it's worth adding upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fpletz
fpletz requested changes Feb 4, 2019
View reviewed changes
nixos/modules/services/misc/airsonic.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/airsonic.nix Outdated Show resolved Hide resolved
@telotortium
airsonic: Add virtualHost option to set up nginx virtual host
027d418 
Modeled after nixos/modules/services/web-apps/tt-rss.nix. The setup is
slightly non-intuitive, so I think it's worth adding upstream.
@telotortium
Copy link
Contributor Author

Hi, could you please take another look at this?

@fpletz
Copy link
Member

fpletz commented Feb 12, 2019

Thanks!

@fpletz fpletz merged commit adb837e into NixOS:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@telotortium @fpletz @GrahamcOfBorg