Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redmine: 3.4.6 -> 3.4.8 (backport) #55022

Merged
merged 1 commit into from Feb 1, 2019
Merged

redmine: 3.4.6 -> 3.4.8 (backport) #55022

merged 1 commit into from Feb 1, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 1, 2019 •
edited

(cherry picked from commit 0f3ecc6)
Backport of #54933

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
redmine: 3.4.6 -> 3.4.8
a349f52 
(cherry picked from commit 0f3ecc6)
@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2019

@GrahamcOfBorg test redmine

@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2019

@Ekleog backport as requested. Tests run fine on my machine. The aarch64 seems to be related to darcs again it looks like. This means that redmine is probably already broken on aarch64 in 18.09 I would imagine. The solution is to get whatever dependency of darcs that is broken fixed, or failing that simply disable darcs support on platforms for which it's broken.

Either way unrelated to this PR in my opinion.

Let me know what you think.

Thanks!

@aanderse aanderse changed the title WIP: redmine: 3.4.6 -> 3.4.8 (backport) redmine: 3.4.6 -> 3.4.8 (backport) Feb 1, 2019
@Ekleog Ekleog merged commit a349f52 into NixOS:release-18.09 Feb 1, 2019
@Ekleog
Copy link
Member

Ekleog commented Feb 1, 2019

The error on aarch64 does look unrelated to this PR indeed. Merged, thank you! 👍

@aanderse aanderse deleted the release-18.09 branch March 2, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Ekleog @GrahamcOfBorg