Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Init mayavi at 4.6.1 #55016

Merged
merged 6 commits into from Feb 9, 2020
Merged

WIP: Init mayavi at 4.6.1 #55016

merged 6 commits into from Feb 9, 2020

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Jan 31, 2019 •
edited

Motivation for this change

This adds the mayavi package. I originally based this on a commit in June 2018 (1d1a4bf), where the mayavi GUI worked. When I rebased it onto current master, something did break, which now leads to a segmentation fault.

Help is very much appreciated.

Edit:
The segfault seems to be due to some environment impurity (QT maybe?), since it runs fine when inside a nix-shell -I nixpkgs=$PWD -p python2Packages.mayavi --pure,
Could probably be fixed via: #54525

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner January 31, 2019 22:22
@costrouc
Copy link
Member

What is the status of this PR?

@knedlsepp
Copy link
Member Author

Needs revisiting now that #54525 could solve the problem.

@knedlsepp knedlsepp changed the base branch from master to staging July 13, 2019 12:00
@knedlsepp knedlsepp force-pushed the init-mayavi-4.6.2 branch 2 times, most recently from 8fc11d3 to cb357e9 Compare July 14, 2019 20:44
@ttuegel ttuegel removed their request for review September 28, 2019 11:59
@knedlsepp knedlsepp changed the base branch from staging to master November 30, 2019 17:32
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

While it may not work, it's in the right direction and I think it's an important package to support, although it is not as popular anymore as it used to be.

@FRidh FRidh merged commit 1a6e93f into NixOS:master Feb 9, 2020
@knedlsepp
Copy link
Member Author

Oh. Thx @FRidh. I forgot about that one already. I'll try to check if applying some wrapqtappshook will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@edwtjo edwtjo Awaiting requested review from edwtjo

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@peti peti Awaiting requested review from peti

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@knedlsepp @costrouc @FRidh @ryantm @GrahamcOfBorg