Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket: add libGL and libGLU to libPath #55002

Merged
merged 1 commit into from Mar 16, 2019
Merged

racket: add libGL and libGLU to libPath #55002

merged 1 commit into from Mar 16, 2019

Conversation

clacke
Copy link
Contributor

@clacke clacke commented Jan 31, 2019

Closes #52990

Motivation for this change

The sgl collection loads them over FFI. If they are not in libPath and therefore LD_LIBRARY_PATH, requiring some modules in sgl will fail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clacke
racket: add libGL and libGLU to libPath
e43a4fa 
The sgl collection loads them over FFI.

Closes NixOS#52990
@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

@GrahamcOfBorg build racket

@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

No idea why this is stuck queued on ofborg, though it would probably time out anyway, but I built and executed it locally successfully.

@srhb srhb merged commit 6d96495 into NixOS:master Mar 16, 2019
srhb pushed a commit that referenced this pull request Mar 16, 2019
@clacke @srhb
racket: add libGL and libGLU to libPath
1870e45 
The sgl collection loads them over FFI.

Closes #52990

Backport of #55002
(cherry picked from commit e43a4fa)
@clacke clacke deleted the racket-gl branch March 18, 2019 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clacke @srhb @7c6f434c @GrahamcOfBorg