Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django-sql-explorer: init at 1.1.2 #55029

Closed
wants to merge 1 commit into from
Closed

pythonPackages.django-sql-explorer: init at 1.1.2 #55029

wants to merge 1 commit into from

Conversation

peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Feb 1, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace reviewed Feb 7, 2019
View reviewed changes
pkgs/development/python-modules/django-sql-explorer/default.nix
@@ -0,0 +1,24 @@
{ stdenv, lib, buildPythonPackage, isPyPy, fetchPypi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, lib, buildPythonPackage, isPyPy, fetchPypi
{ stdenv, lib, buildPythonPackage, fetchPypi

@peterromfeldhk
Copy link
Contributor Author

need to rethink django stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterromfeldhk @worldofpeace @GrahamcOfBorg