pythonPackages.bumpversion: init at 0.5.3 #55034
Conversation
GrahamcOfBorg
added
6.topic: python
8.has: package (new)
| @@ -0,0 +1,24 @@ | |||
| { stdenv, lib, buildPythonPackage, fetchFromGitHub }: | |||
|
|
|||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
Isn't this an application rather than a library?
There was a problem hiding this comment.
its in devDependencies for the project i try to package up.. but i guess it can be used as a application
There was a problem hiding this comment.
Are you sure it's used as import bumpversion there? Also, I've sometimes seen the case that an application is imported just to call its main function, what could have been done using subprocess.call().
| description = "Version-bump your software with a single command"; | ||
| homepage = https://github.com/peritus/bumpversion; | ||
| maintainers = with maintainers; [ peterromfeldhk ]; | ||
| license = with licenses; [ mit ]; |
There was a problem hiding this comment.
| license = with licenses; [ mit ]; | |
| license = licenses.mit; |
| @@ -0,0 +1,24 @@ | |||
| { stdenv, lib, buildPythonPackage, fetchFromGitHub }: | |||
|
|
|||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
Are you sure it's used as import bumpversion there? Also, I've sometimes seen the case that an application is imported just to call its main function, what could have been done using subprocess.call().
| sha256 = "08zjxa9k15jrvjy7j7qbwjkggcisbx2x4yh5rva4slnjrk3qhmx8"; | ||
| }; | ||
|
|
||
| # checkInputs = [ pytest mock git mercurial ]; |
There was a problem hiding this comment.
No need to comment these out. They won't be used unless checks are enabled.
|
Are there any updates on this pull request, please? |
|
Nothing happening so closing. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)