Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papis: 0.6 -> 0.7.5 #55009

Merged
merged 4 commits into from Feb 2, 2019
Merged

papis: 0.6 -> 0.7.5 #55009

merged 4 commits into from Feb 2, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @teto @dtzWill @nico202

@dtzWill
Copy link
Member

dtzWill commented Jan 31, 2019

LGTM! And upstream merged your dateparser fixes so we can use 3.7 again once there's a release or we pick the changes or w/e (sounds like you've got it under control ❤️).

Haha I apparently have a small set of documents from looking into this last time 'round xD.

pname = "filetype";
version = "1.0.2";

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I personnally have no complaint with this, I am often asked when upstreaming packages why I didn't use fetchPypi.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I forgot to add a comment.

{ lib, fetchFromGitHub, bashInteractive
, python3, vim
{ lib, fetchFromGitHub, fetchpatch
, python36, xdg_utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's cleaner to pass buildPythonApplication here and do papis = python36Packages.callPackage ../tools/misc/papis { }; in all-packages.nix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's discouraged because it doesn't allow the overriding of Python packages for specific applications.

@teto
Copy link
Member

teto commented Feb 1, 2019

Would be cool to get the bash autocompletion too. According to doc/source/shell_completion.rst, pip generates one in /usr/local/etc/bash_completion.d/papis

@teto
Copy link
Member

teto commented Feb 1, 2019

I've tested things a bit and browse / export /add work.. Thanks for the great work ! Looking forward to this.
Some commands might need additionnal packages like scihub support https://papis.readthedocs.io/en/latest/scihub.html or the zotero import. Probably users just need to override the buildInputs.

@dotlambda
Copy link
Member Author

Would be cool to get the bash autocompletion too.

Done.

@dotlambda dotlambda merged commit 230d55e into NixOS:master Feb 2, 2019
@dotlambda dotlambda deleted the papis-0.7.5 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants