Skip to content

linuxPackages.bcc: fix build #56833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2019
Merged

linuxPackages.bcc: fix build #56833

merged 1 commit into from
Mar 9, 2019
+1 −1

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 4, 2019

flex is needed as buildInput too (headers, libfl),
recent strictDeps change in python caught this.

Fixes #56724

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dtzWill
linuxPackages.bcc: fix build
a55c66c 
flex is needed as buildInput too (headers, libfl),
recent strictDeps change in python caught this.

Fixes NixOS#56724
@GrahamcOfBorg GrahamcOfBorg requested a review from Mic92 March 4, 2019 18:21
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 4, 2019
@vcunat vcunat merged commit a55c66c into NixOS:master Mar 9, 2019
vcunat added a commit that referenced this pull request Mar 9, 2019
@vcunat
Merge #56833: linuxPackages.bcc: fix build
52565a8 
(cherry picked from commit 84be644)
vcunat added a commit that referenced this pull request Mar 9, 2019
@vcunat
Merge #56833: linuxPackages.bcc: fix build
84be644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@vcunat vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @Mic92 @vcunat @GrahamcOfBorg