New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Separate forbid 90 deg for trains and ships #7314
Change: Separate forbid 90 deg for trains and ships #7314
Conversation
/* Filter out trackdirs that would make 90 deg turns for trains */ | ||
if (_settings_game.pf.forbid_90_deg && (type == TRANSPORT_RAIL || type == TRANSPORT_WATER)) trackdirbits &= ~TrackdirCrossesTrackdirs(src_trackdir); | ||
/* Filter out trackdirs that would make 90 deg turns for trains and ships */ | ||
if (_settings_game.pf.forbid_90_deg && type == TRANSPORT_RAIL || _settings_game.pf.forbid_90_deg_ships && type == TRANSPORT_WATER) trackdirbits &= ~TrackdirCrossesTrackdirs(src_trackdir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parenthesis!
src/saveload/saveload.h
Outdated
@@ -291,6 +291,7 @@ enum SaveLoadVersion : uint16 { | |||
SLV_GROUP_LIVERIES, ///< 205 PR#7108 Livery storage change and group liveries. | |||
SLV_SHIPS_STOP_IN_LOCKS, ///< 206 PR#7150 Ship/lock movement changes. | |||
SLV_FIX_CARGO_MONITOR, ///< 207 PR#7175 Cargo monitor data packing fix to support 64 cargotypes. | |||
SLV_FORBID_90_DEG_SHIPS, ///< 208 Separate Forbid 90-deg settings for trains and ships. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add the PR number now it is open.
It is #7314.
83df027
to
6659f88
Compare
We don't need a setting to forbid 90 degrees for ships. I'm closing this one, thanks! |
Actually no, let someone else decide. I don't trust my judgement at the moment. Time for a break from OpenTTD. |
No, you were spot on. But to give a bit of argumentation: Most people favor that no-90-degree is for trains only, so I suggest we pick that path. Scheduled #7232 for 1.10, and closing this in favor of that! I like that we find multiple solutions for the same problem. Means we can pick the one we like most :) And sorry, this time this isn't yours; possibly next time! |
https://www.tt-forums.net/viewtopic.php?p=1184322#p1184322
This patch splits the game setting "Forbid trains and ships from making 90º turns" into 2 separate settings: